Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle arch as array and gpu-env and switch to base repo for sample #136

Merged
merged 3 commits into from
Jan 25, 2024
Merged

fix: handle arch as array and gpu-env and switch to base repo for sample #136

merged 3 commits into from
Jan 25, 2024

Conversation

jeffmaury
Copy link
Contributor

No description provided.

@jeffmaury jeffmaury requested review from feloy and lstocchi January 25, 2024 11:11
@jeffmaury
fix: code smell from lint report
cdddca1 
Signed-off-by: Jeff MAURY <[email protected]>
@jeffmaury
fix: unit test
68ed5cd 
Signed-off-by: Jeff MAURY <[email protected]>
lstocchi
lstocchi approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmaury jeffmaury merged commit bab96a0 into containers:main Jan 25, 2024
3 checks passed
@jeffmaury jeffmaury deleted the GH-132 branch January 25, 2024 12:44
@jeffmaury jeffmaury mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lstocchi lstocchi lstocchi approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffmaury @lstocchi